Oolite Bulletins

For information and discussion about Oolite.
It is currently Wed Sep 20, 2017 7:29 am

All times are UTC




Post new topic  Reply to topic  [ 7 posts ] 
Author Message
PostPosted: Tue Mar 07, 2017 10:06 pm 
Offline
Above Average
Above Average

Joined: Sun Oct 30, 2016 12:34 pm
Posts: 19
Hi there,

I would like to present you my first OXP:
The SecComFinder (<- click to download from the wiki) for the [EliteWiki] Galactic Navy OXP.
If both, the Galactic Navy OXP and the SecComFinder are installed, systems with [EliteWiki] Navy SecCom Stations are marked in the ingame galaxy chart.
After uninstalling Galactic Navy OXP, leave SecComFinder installed to let it remove the makers it made. Load and save your game state once after that and you can uninstall SecComFinder too.

Why did i create this OXP:
Many weeks ago i installed "Galactic Navy OXP". Too bad the only way i knew to find out where the next SecCom Station is were [EliteWiki] those maps: Looking in the browser and going back to Oolite made me think "There must be a way to mark the systems where SecCom stations are located. I just got to find out how." So, about one month ago i found out, learning (about) javascript the hard way: Look at other OXP scripts and try similar. With a lots of "try and error". Almost three weeks ago, after 20 to 30 hours, scattered over four to six days, scattered over three weeks i "finished" the oxp. "Finishing" means it works as intended without creating errors in the logfile. The last three weeks i "tested" (more than necessary) the OXP intensely. Today, i finally bestired myself to create the wiki entry and this thread to help you to pull your duty in the Galactiv Navy.


Last edited by Runghold on Tue Mar 07, 2017 10:22 pm, edited 1 time in total.

Top
   
PostPosted: Tue Mar 07, 2017 10:07 pm 
Offline
Above Average
Above Average

Joined: Sun Oct 30, 2016 12:34 pm
Posts: 19
Some things to discuss for possible future versions:
  • In the script, this marker is used:
    markerColor: "cyanColor", markerScale: 1.5, markerShape: "MARKER_DIAMOND"
    what marker could be better and why?
  • In manifest.plist, these categories are specified:
    "category" = "Activities";
    "category" = "Misc";
    "category" = "Missions";
    "category" = "Systems";
    The bad thing is:
    If an OXZ has several categories specified, it may be listed in the managed addons list under one or another category - dependant if is installed yet. I discovered this when i installed all on my PC installed managed addons on my notebook.
    Which category is the most appropriate and why?
  • In manifest.plist/requires.plist:
    "required_oolite_version" = "1.79";
    The script shouldn't run in a version less than Oolite 1.79, but does it run from 1.79 up?
  • How could the code be changed to work more efficiently?


Top
   
PostPosted: Wed Mar 08, 2017 3:43 am 
Offline
Commodore
Commodore
User avatar

Joined: Tue Jan 21, 2014 10:37 pm
Posts: 1701
Location: [p]laying [h]ard and [k]icking [b]utt somewhere in G7...
Quote:
If an OXZ has several categories specified, it may be listed in the managed addons list under one or another category
I think you can only have one category assigned to an OXP, the others should go in "tags".
Quote:
Which category is the most appropriate and why?
I'd suggest Misc or Ambience.
Quote:
How could the code be changed to work more efficiently?
You could have a look at how I accomplished something similar with the [EliteWiki] Galactic Registry OXP

_________________
My OXP's


Top
   
PostPosted: Wed Mar 08, 2017 8:00 am 
Offline
Above Average
Above Average

Joined: Sun Oct 30, 2016 12:34 pm
Posts: 19
Quote:
You could have a look at how I accomplished something similar with the [EliteWiki] Galactic Registry OXP
Quote from that wiki page:
Quote:
...
This will highlight each system that is home to a GalNavy sector command
...
Well... i guess if i knew about Galactic Registry OXP before i wouldn't have created SecComFinder since its only feature is already included in Galactic Registry. :?


Top
   
PostPosted: Wed Mar 08, 2017 9:02 pm 
Offline
Commodore
Commodore
User avatar

Joined: Tue Jan 21, 2014 10:37 pm
Posts: 1701
Location: [p]laying [h]ard and [k]icking [b]utt somewhere in G7...
Sorry! But just because I have a similar feature in GalCop Galactic Registry, doesn't mean your version is obsolete. You're putting the markers up permanently, so they will be visible on every chart screen (including any mission screens that use a chart). For users of the GalNavy OXP this might be preferable. That's different to the Gal Registry, which only shows them while you're on the Gal Registry screen.

It's a big Ooniverse out there - variations of OXP implementations is OK.

_________________
My OXP's


Top
   
PostPosted: Sat Mar 25, 2017 6:48 pm 
Offline
Dangerous
Dangerous
User avatar

Joined: Sun Jan 08, 2006 7:32 pm
Posts: 105
I use this OXP. It would be nice to add RRS stations to this. [Edit: RRS, not RSS..]

The list of systems with RRS Galactic Headquarters is [EliteWiki] published, but as far as I know, there is no public list/map of Waystations.
So publishing those might be considered a spoiler. But then again, anyone who would think that is free to not install it.. Also, there are way more waystations than SecCom stations, so it might make the map look cluttered.
Anyway, just an idea.



Edit to add:

So no longer just an idea. I looked at your script in your OXP and at the script in the RRS OXP,
and pretty much just replicated what you do, with the help of some functions in the RRS script.
I added the following snippet to your FuncGalaxyCheck() function:
Code:
var rrs = worldScripts["Rescue Stations"];
if (rrs)
{
	for (var s = 0;s < 256;s++)
	{
		if (rrs.systemHasRescueStation(s))
		{
			mission.markSystem(
				{system:  s, name: "RungholdRRS_WS_g" + galaxyNumber + "s" + s, markerColor: "blueColor", markerScale: 1.25, markerShape: "MARKER_DIAMOND"}
							   );
		}
		if (rrs.systemHasRescueHQStation(s))
		{
			mission.markSystem(
				{system:  s, name: "RungholdRRS_HQ_g" + galaxyNumber + "s" + s, markerColor: "blueColor", markerScale: 1.25, markerShape: "MARKER_SQUARE"}
							   );
		}
	}
}
It appears to work as intended, and yes, it does make the map look somewhat cluttered:

Image

The one near the center with the diamond and the square, making an 8 point star, has both a waystation and the galactic HQ.


Last edited by hoqllnq on Tue Apr 04, 2017 3:37 pm, edited 1 time in total.

Top
   
PostPosted: Tue Apr 04, 2017 1:43 pm 
Offline
Above Average
Above Average

Joined: Sun Oct 30, 2016 12:34 pm
Posts: 19
I am pleased to read that someone besides me is using my OXP.

At the moment that annoying real life is keeping me from scripting so i will - if at all - just try to optimize the code if i find the time. But i like the idea of including the ability to set markers for other OXPs too. Maybe in the future i will mess with it.


regards

Runghold


Top
   
Display posts from previous:  Sort by  
Post new topic  Reply to topic  [ 7 posts ] 

All times are UTC


Who is online

Users browsing this forum: No registered users and 15 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum

Search for:
cron
Powered by phpBB® Forum Software © phpBB Limited