SHORT_RANGE_CHART special background issue (Resolved)

For test results, bug reports, announcements of new builds etc.

Moderators: winston, another_commander, Getafix

Post Reply
User avatar
phkb
Commodore
Commodore
Posts: 2433
Joined: Tue Jan 21, 2014 10:37 pm
Location: [p]laying [h]ard and [k]icking [b]utt somewhere in G7...

SHORT_RANGE_CHART special background issue (Resolved)

Post by phkb » Fri Feb 05, 2016 2:45 am

The option of using the SHORT_RANGE_CHART special background on mission screens is a bit hit-and-miss. It appears that currently Oolite takes whatever the current zoom and position settings from the F6 screen, and reproduces them for the SHORT_RANGE_CHART. This can mean the SHORT_RANGE_CHART ends up looking like the LONG_RANGE_CHART, if you left the F6 screen zoomed all the way out, or it could mean that the SHORT_RANGE_CHART is focused on the wrong part of the chart, if you zoomed in on a planet other than the one you're currently at.

I guess this is both a feature request and a bug notice. It's a bug notice because there's little point in using the SHORT_RANGE_CHART in it's current state, as there's no guarantee it will display what you want it to display. But it's a feature request, expanding on the suggestion here, to give programmers two new parameters: zoom (to control the SRC zoom level), and systemID (to select what planet the SRC should be centred on).
Last edited by phkb on Sun Feb 14, 2016 8:23 am, edited 1 time in total.

User avatar
kanthoney
Commodore
Commodore
Posts: 281
Joined: Thu Nov 07, 2013 10:21 pm

Re: SHORT_RANGE_CHART special background issue

Post by kanthoney » Fri Feb 05, 2016 6:03 pm

Hmm, not sure about the best way to do that. If you've got the chart set to a zoom level you like then you probably don't want the mission screen resetting it for you, so I guess you'd want it to zoom back to your usual setting when you leave the mission screen.

I'll have a look at this when I get a chance.

User avatar
phkb
Commodore
Commodore
Posts: 2433
Joined: Tue Jan 21, 2014 10:37 pm
Location: [p]laying [h]ard and [k]icking [b]utt somewhere in G7...

Re: SHORT_RANGE_CHART special background issue

Post by phkb » Fri Feb 05, 2016 11:16 pm

Thanks, kanthoney!

User avatar
kanthoney
Commodore
Commodore
Posts: 281
Joined: Thu Nov 07, 2013 10:21 pm

Re: SHORT_RANGE_CHART special background issue

Post by kanthoney » Fri Feb 12, 2016 9:00 pm

I've hopefully fixed this in tonight's build. It should revert to the old behaviour, showing the chart either fully zoomed in or fully zoomed out depending on whether you're using the short range or long range chart.

Let me know if something's broken.

User avatar
phkb
Commodore
Commodore
Posts: 2433
Joined: Tue Jan 21, 2014 10:37 pm
Location: [p]laying [h]ard and [k]icking [b]utt somewhere in G7...

Re: SHORT_RANGE_CHART special background issue

Post by phkb » Sun Feb 14, 2016 5:32 am

kanthoney, you are a legend! All tested beautifully! Thanks for addressing this issue so promptly!

Post Reply