Gems sold when not buying ship

For test results, bug reports, announcements of new builds etc.

Moderators: winston, another_commander, Getafix

Post Reply
User avatar
Day
---- E L I T E ----
---- E L I T E ----
Posts: 518
Joined: Tue Mar 03, 2015 11:35 am
Location: Paris

Gems sold when not buying ship

Post by Day » Sun Aug 02, 2015 8:38 pm

Hello all,

I'm on a 1.82 compiled at home, loaded with lots of oxp/z.

When I ask to see a ship to maybe buy it, my gems are sold. After having said "No, I don't want to buy this ship", I see that I have zero gems.

Among the oxp/z I have installed, there are Carriers and Hyperspace Hangar. Edit: ShipVersion too.

I'm not blocked because of that bug, because I don't want to buy a new ship yet. But I thought it could be useful to somebody to signal it.
Last edited by Day on Tue Aug 04, 2015 11:54 am, edited 1 time in total.

another_commander
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 5396
Joined: Wed Feb 28, 2007 7:54 am

Re: Gems sold when not buying ship

Post by another_commander » Sun Aug 02, 2015 9:18 pm

That's not a core game bug, is it? I don't recall the standard game asking if you want to buy a ship or not.

User avatar
cim
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 4018
Joined: Fri Nov 11, 2011 6:19 pm

Re: Gems sold when not buying ship

Post by cim » Sun Aug 02, 2015 9:39 pm

As I recall the OXPs which give the player the option work by intercepting the event for the player having already bought the ship and then giving them the option to undo that decision. It's quite possible that they don't put everything back exactly as it was found.

User avatar
Day
---- E L I T E ----
---- E L I T E ----
Posts: 518
Joined: Tue Mar 03, 2015 11:35 am
Location: Paris

Re: Gems sold when not buying ship

Post by Day » Mon Aug 03, 2015 11:42 am

@another_commander: I would not think this is a core game bug.
It would have been spotted sooner.

@cim: ah ok. It would explain why I hear a "selling event" sound.
Would you recall which oxp offers this functionality ?

So it is an oxp bug.
Is this thread in the right section, or should it be moved into the oxp section ?

User avatar
Cody
Sharp Shooter Spam Assassin
Sharp Shooter Spam Assassin
Posts: 13635
Joined: Sat Jul 04, 2009 9:31 pm
Location: Corke's Drift
Contact:

Re: Gems sold when not buying ship

Post by Cody » Mon Aug 03, 2015 11:46 am

OXP bugs should go in the relevant OXP's thread.

User avatar
Day
---- E L I T E ----
---- E L I T E ----
Posts: 518
Joined: Tue Mar 03, 2015 11:35 am
Location: Paris

Re: Gems sold when not buying ship

Post by Day » Mon Aug 03, 2015 11:49 am

Thank you Cody.

The relevant oxp is not yet identified.

User avatar
Lone_Wolf
---- E L I T E ----
---- E L I T E ----
Posts: 545
Joined: Wed Aug 08, 2007 10:59 pm
Location: Netherlands

Re: Gems sold when not buying ship

Post by Lone_Wolf » Mon Aug 03, 2015 1:12 pm

Carriers oxp doesn't have a this.playerBoughtNewShip = function() handler so, it's not that one.

Ship storage helper also doesn't have it, hyperspace hangar does.

HH does seem to use SSH for the undo function .
Looking into SSH code it seems it doesn't store the normal cargo a ship has .

I suggest to wait a bit for Norby and/or Ramen to comment.
OS : Arch Linux 64-bit - rolling release

OXPs : My user page

I am subscribed to the threads for my oxps, if you need my attention just post in them or send a pm.

User avatar
Norby
---- E L I T E ----
---- E L I T E ----
Posts: 2543
Joined: Mon May 20, 2013 9:53 pm
Location: Budapest, Hungary (Mainly Agricultural Democracy, TL10)
Contact:

Re: Gems sold when not buying ship

Post by Norby » Mon Aug 03, 2015 6:48 pm

Lone_Wolf wrote:HH does seem to use SSH for the undo function.
Looking into SSH code it seems it doesn't store the normal cargo a ship has.
Probably SSH need further fixes both about cargo and multiple passenger berth handling.
ShipVersion is the other OXP which pop up a confirmation screen "before" buy a ship (technically after due to set back the previous ship in the playerBoughtNewShip event handler if refused), also need a fix or a change to use the function of SSH instead.
I can not promise a deadline of these fixes, until then try changing your ship without cargo only.

User avatar
Day
---- E L I T E ----
---- E L I T E ----
Posts: 518
Joined: Tue Mar 03, 2015 11:35 am
Location: Paris

Re: Gems sold when not buying ship

Post by Day » Tue Aug 04, 2015 11:54 am

I installed ShipVersion OXP too.

User avatar
Day
---- E L I T E ----
---- E L I T E ----
Posts: 518
Joined: Tue Mar 03, 2015 11:35 am
Location: Paris

Re: Gems sold when not buying ship

Post by Day » Tue Aug 04, 2015 11:56 am

Norby wrote:I can not promise a deadline of these fixes, until then try changing your ship without cargo only.
No worries :-)
And thank you.

Post Reply