Not buying a ship lets you with sold equipments

For test results, bug reports, announcements of new builds etc.

Moderators: winston, another_commander, Getafix

Post Reply
User avatar
Day
---- E L I T E ----
---- E L I T E ----
Posts: 518
Joined: Tue Mar 03, 2015 11:35 am
Location: Paris

Not buying a ship lets you with sold equipments

Post by Day » Sun May 31, 2015 3:46 pm

I'm on a Linux (Ubuntu) with a 1.82 version (compiled myself, "release", not "debug").

I've got the Hyperspace Hangar OXZ installed and I've got enough money to buy a new ship without selling the previous one.
When I'm buying a ship, and then saying "No I don't want to buy this ship", i'm let with my ship but without my equipment.

It happens when buying a Krait, but not when buying a Python (strange, that). It is reproducible.

This could be related to the Hyperspace Hanger OXZ, or not at all.

What do you think ?

PS: no hurry, I didn't save.

User avatar
Smivs
Retired Assassin
Retired Assassin
Posts: 8408
Joined: Tue Feb 09, 2010 11:31 am
Location: Disunited Kingdom
Contact:

Re: Not buying a ship lets you with sold equipments

Post by Smivs » Sun May 31, 2015 3:50 pm

Might it be that the ship you are buying cannot have that equipment?
Commander Smivs, the friendliest Gourd this side of Riedquat.

User avatar
Day
---- E L I T E ----
---- E L I T E ----
Posts: 518
Joined: Tue Mar 03, 2015 11:35 am
Location: Paris

Re: Not buying a ship lets you with sold equipments

Post by Day » Sun May 31, 2015 3:54 pm

Smivs wrote:Might it be that the ship you are buying cannot have that equipment?
Interesting idea, but the "Beer cooler" and the "Tea maker" were part of those equipments.

EDIT: the Express Team Maker was not part og the equipments.
I wa able to buy the Krait, and then to buy back The Beer cooler.
Last edited by Day on Sun May 31, 2015 3:59 pm, edited 1 time in total.

User avatar
Smivs
Retired Assassin
Retired Assassin
Posts: 8408
Joined: Tue Feb 09, 2010 11:31 am
Location: Disunited Kingdom
Contact:

Re: Not buying a ship lets you with sold equipments

Post by Smivs » Sun May 31, 2015 3:59 pm

Ah, I mis-understood, sorry. I thought at first that that you meant the new ships wasn't getting equipment, which I could understand.
If you are left with no equipment at all, that suggests that the OXP is selling your ship then re-purchasing it, but as the basic model. I'm only guessing as I have not used or even looked at the Hyperspace hanger so have no idea how it actually works.
Commander Smivs, the friendliest Gourd this side of Riedquat.

User avatar
Day
---- E L I T E ----
---- E L I T E ----
Posts: 518
Joined: Tue Mar 03, 2015 11:35 am
Location: Paris

Re: Not buying a ship lets you with sold equipments

Post by Day » Sun May 31, 2015 4:00 pm

Ok, if you think the problem lies into the Hyperspace Hangar, I'll look into this.
Thank you :-)

User avatar
Smivs
Retired Assassin
Retired Assassin
Posts: 8408
Joined: Tue Feb 09, 2010 11:31 am
Location: Disunited Kingdom
Contact:

Re: Not buying a ship lets you with sold equipments

Post by Smivs » Sun May 31, 2015 4:05 pm

Day wrote:...if you think the problem lies into the Hyperspace Hangar...
Ha, I didn't quite say that - I was just speculating from a position of total ignorance :) It might be the culprit of course, so it might be worth following up anyway.
Commander Smivs, the friendliest Gourd this side of Riedquat.

User avatar
Day
---- E L I T E ----
---- E L I T E ----
Posts: 518
Joined: Tue Mar 03, 2015 11:35 am
Location: Paris

Re: Not buying a ship lets you with sold equipments

Post by Day » Sun May 31, 2015 4:22 pm

Smivs wrote:
Day wrote:...if you think the problem lies into the Hyperspace Hangar...
Ha, I didn't quite say that - I was just speculating from a position of total ignorance :) It might be the culprit of course, so it might be worth following up anyway.
Sorry. ^^ Well, I think it's a good idea to look in this direction.

Layne
---- E L I T E ----
---- E L I T E ----
Posts: 355
Joined: Sat Mar 28, 2015 11:14 pm

Re: Not buying a ship lets you with sold equipments

Post by Layne » Sun May 31, 2015 4:43 pm

Am I correct in the belief that Hyperspace Hangar requires the Ship Storage Helper OXP to operate? I have noticed one or two pieces of equipment that the Ship Storage Helper seems to 'lose', forcing you to have to re-purchase. I have not looked at the Storage Helper OXP in detail to determine exactly why, though.
Reports of my death have been greatly underestimated.

User avatar
Norby
---- E L I T E ----
---- E L I T E ----
Posts: 2543
Joined: Mon May 20, 2013 9:53 pm
Location: Budapest, Hungary (Mainly Agricultural Democracy, TL10)
Contact:

Re: Not buying a ship lets you with sold equipments

Post by Norby » Sun May 31, 2015 5:33 pm

Layne wrote:I have noticed one or two pieces of equipment that the Ship Storage Helper seems to 'lose'
I maybe can fix Ship Storage Helper if you send me a savegame or at least the details about how can I reproduce the problem. Please make sure you have the latest version due to similar problems was fixed recently.

Layne
---- E L I T E ----
---- E L I T E ----
Posts: 355
Joined: Sat Mar 28, 2015 11:14 pm

Re: Not buying a ship lets you with sold equipments

Post by Layne » Sun May 31, 2015 6:03 pm

Norby wrote:
Layne wrote:I have noticed one or two pieces of equipment that the Ship Storage Helper seems to 'lose'
I maybe can fix Ship Storage Helper if you send me a savegame or at least the details about how can I reproduce the problem. Please make sure you have the latest version due to similar problems was fixed recently.

Sorry, haven't any logs-- I only had the Storage Helper installed so I could test out bug fixes for my Docking Fees OXP when used with the Combat Simulator (which also requires the Storage Helper). It's not an OXP I usually use. The main piece of equipment that was vanishing after every combat simulation was the Shield-Cycler. After I was finished testing the bug fixes for the Docking Fees mod, I removed both Combat Simulator and Ship Storage Helper, as I did not plan to use them normally.
Reports of my death have been greatly underestimated.

User avatar
Day
---- E L I T E ----
---- E L I T E ----
Posts: 518
Joined: Tue Mar 03, 2015 11:35 am
Location: Paris

Re: Not buying a ship lets you with sold equipments

Post by Day » Sun May 31, 2015 6:08 pm

Layne wrote:Am I correct in the belief that Hyperspace Hangar requires the Ship Storage Helper OXP to operate? I have noticed one or two pieces of equipment that the Ship Storage Helper seems to 'lose', forcing you to have to re-purchase. I have not looked at the Storage Helper OXP in detail to determine exactly why, though.
Yes, Hyperspace Hangar needs Ship Storage.

User avatar
Day
---- E L I T E ----
---- E L I T E ----
Posts: 518
Joined: Tue Mar 03, 2015 11:35 am
Location: Paris

Re: Not buying a ship lets you with sold equipments

Post by Day » Sun May 31, 2015 6:09 pm

Norby wrote:
Layne wrote:I have noticed one or two pieces of equipment that the Ship Storage Helper seems to 'lose'
I maybe can fix Ship Storage Helper if you send me a savegame or at least the details about how can I reproduce the problem. Please make sure you have the latest version due to similar problems was fixed recently.
I can send you a savegame if you think it could be related to Ship Storage Helper.

User avatar
Lone_Wolf
---- E L I T E ----
---- E L I T E ----
Posts: 545
Joined: Wed Aug 08, 2007 10:59 pm
Location: Netherlands

Re: Not buying a ship lets you with sold equipments

Post by Lone_Wolf » Mon Jun 01, 2015 10:08 pm

Layne wrote:The main piece of equipment that was vanishing after every combat simulation was the Shield-Cycler.
As shield cycler requires intensive modification of a ship, it can't be transferred when you change ships.
Upon buying a new ship Shield cycler devices are reset completely ( you do get a refund)

Edit :
Looks like it's already fixed.

SSH change log :
v0.24 13/04/15 - Fixed equipment restore if a required equipment comes later in the list. Fixed Shield Cycler cashback at ship restore.
OS : Arch Linux 64-bit - rolling release

OXPs : My user page

I am subscribed to the threads for my oxps, if you need my attention just post in them or send a pm.

User avatar
Lone_Wolf
---- E L I T E ----
---- E L I T E ----
Posts: 545
Joined: Wed Aug 08, 2007 10:59 pm
Location: Netherlands

Re: Not buying a ship lets you with sold equipments

Post by Lone_Wolf » Tue Jun 02, 2015 12:06 pm

(this will also be posted in SSH thread)

I looked at the code of Ship Storage Helper and Day's issue is not solved.

I do not intend for Shleld Cycler to become PortableBetweenShips , but putting the ship in storage and retrieving it with SC intact should be possible .

Currently i see 2 problems for SSH :

- replaceShip calls playerBoughtNewShip, this triggers SC to remove all traces of SC and give some cash back.
to avoid the cashback, SSH resets SC values .

- upon retrieval of the ship, SC should be restored but they aren't atm.

I think the following approach should work to solve all problems :

- add 2 methods to shield Cycler :

Method A : Store SC values
copy SC Values to a temporary object using JSON , include a flag in this object to signify failure / success
reset SC values in savegame
return the temp object

Method B : retrieve SC Values
calling oxp needs to pass an object holding SC values
SC applies the values (similar to what it does on savegame loading)
return a flag to signal failure/success

SSH should then do this :
before replaceShip , call SC Method A
verify if SC Method A was succesfull
store the Object holding SC values in an SSH savegame var

Upon retrieving the stored ship :
retrieve the SSH savegamevar holding the SC values to a temp object
call SC Method B, passing the temp object
verify if SC Method B is succesfull
OS : Arch Linux 64-bit - rolling release

OXPs : My user page

I am subscribed to the threads for my oxps, if you need my attention just post in them or send a pm.

Post Reply