[Solved] Illegal Goods Problem - Oolite 1.81 (trunk)

For test results, bug reports, announcements of new builds etc.

Moderators: winston, another_commander, Getafix

Post Reply
User avatar
CommRLock78
---- E L I T E ----
---- E L I T E ----
Posts: 1132
Joined: Sat Apr 07, 2012 7:35 pm
Location: US
Contact:

[Solved] Illegal Goods Problem - Oolite 1.81 (trunk)

Post by CommRLock78 » Sun Mar 01, 2015 11:51 pm

Greetings! There seems to be a bug with IG when you dock to meet with a relative a freed slave. The spacebar doesn't move seem to work, so I get stuck there on this screen:
https://dl.dropboxusercontent.com/u/959 ... Thanks.png

Here's the latest log:
https://dl.dropboxusercontent.com/u/95921622/Latest.log

It appears the relevent messages start about line 1763.

Edit: It looks like mission.unmarkSystem no longer uses numbers ( :?: )

Edit 2: Fixed conflict with Email System and Illegal Good Tweak
Last edited by CommRLock78 on Tue Mar 03, 2015 8:46 pm, edited 1 time in total.
"I'll laser the mark all while munching a fistful of popcorn." - Markgräf von Ededleen, Marquess, Brutal Great One, Assassins' Guild Exterminator
---------------------------
At the helm of the Caduceus Omega, 'Murderous Morrígan'

User avatar
cim
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 4018
Joined: Fri Nov 11, 2011 6:19 pm

Re: Illegal Goods Problem - Oolite 1.81 (trunk)

Post by cim » Mon Mar 02, 2015 7:23 am

16:33:17.930 [oxp-standards.deprecated]: Use of numbers for mission.unmarkSystem is deprecated
Harmless - though using the new format would allow more control over the mission markers and prevent other OXPs from accidentally overwriting them. "deprecated" is just a hint to OXP authors that there's a better way available now, and that log message won't even appear in non-developer builds of Oolite.
16:33:17.933 [script.javaScript.exception.uncaughtException]: ***** JavaScript exception (illegal_goods_missions 2.0.0): uncaught exception: Invalid settings: sender must be supplied.
This will be what's causing the problem - but the message "Invalid settings: sender must be supplied." doesn't appear anywhere in the Oolite source, so I suspect an OXP problem. Which OXP, I don't know.

User avatar
Wildeblood
---- E L I T E ----
---- E L I T E ----
Posts: 2161
Joined: Sat Jun 11, 2011 6:07 am
Location: Western Australia
Contact:

Re: Illegal Goods Problem - Oolite 1.81 (trunk)

Post by Wildeblood » Mon Mar 02, 2015 7:38 am

cim wrote:
16:33:17.933 [script.javaScript.exception.uncaughtException]: ***** JavaScript exception (illegal_goods_missions 2.0.0): uncaught exception: Invalid settings: sender must be supplied.
This will be what's causing the problem - but the message "Invalid settings: sender must be supplied." doesn't appear anywhere in the Oolite source, so I suspect an OXP problem. Which OXP, I don't know.
Email system. Every email it sends has a sender specified, but some are as literal text and some are like this:-
w.$createEmail({sender:expandMissionText("[mission_ig_contactname]"),
subject:"Eternal Gratitude",
date:global.clock.seconds,
message:expandMissionText("end_mission_email")}
);
I suspect the missiontext expansion.

User avatar
phkb
Commodore
Commodore
Posts: 2403
Joined: Tue Jan 21, 2014 10:37 pm
Location: [p]laying [h]ard and [k]icking [b]utt somewhere in G7...

Re: Illegal Goods Problem - Oolite 1.81 (trunk)

Post by phkb » Mon Mar 02, 2015 9:37 am

Yep, my bad. Last minute changes are a bad idea. Note to self.

New version on the way.

User avatar
CommRLock78
---- E L I T E ----
---- E L I T E ----
Posts: 1132
Joined: Sat Apr 07, 2012 7:35 pm
Location: US
Contact:

Re: Illegal Goods Problem - Oolite 1.81 (trunk)

Post by CommRLock78 » Tue Mar 03, 2015 8:44 pm

Thanks for fixing those things so quickly Phkb! :mrgreen: :mrgreen: :mrgreen: 8)
"I'll laser the mark all while munching a fistful of popcorn." - Markgräf von Ededleen, Marquess, Brutal Great One, Assassins' Guild Exterminator
---------------------------
At the helm of the Caduceus Omega, 'Murderous Morrígan'

Post Reply